fix: Map offset on edge

[ptbrowne]

We have logic to watch the height of the container for chart and table
in published view. This is to ensure that when switching from table
to chart, we have no jump of content.
Before, we would watch the height automatically and it sometimes would
make the container a bit too short to accomodate the map when it mounts.
I suspect it would for a brief time show scrollbars on Edge, and those
scrollbars would offset the layers that were drawn at this point.

Now, we measure the height just before switching to the other view,
instead of doing it continuously. This ensures that the height is stable
and it removes the geojson layers offset bug on Edge.

fix #723

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
visualization-tool	✅ Ready (Inspect)	Visit Preview	Sep 20, 2022 at 10:08AM (UTC)

[bprusinowski]

LGTM, really nice! 👏

Nit: I wonder if it makes sense to maybe extract this logic into a hook, as I think it's duplicated right now across chart preview and chart published? What do you think?

[ptbrowne]

Nit: I wonder if it makes sense to maybe extract this logic into a hook, as I think it's duplicated right now across chart preview and chart published? What do you think?

Done 👍

[Rdataflow]

@ptbrowne thx for your fix.

unfortunately the fix only helped for published maps. the error ist still present in edit mode :-(

cc @sosiology