Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cube search does not use full text search engine #726

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

ptbrowne
Copy link
Collaborator

Removing full text search and use simple contain for search.

@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
visualization-tool ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 9:04AM (UTC)

@ptbrowne
Copy link
Collaborator Author

@adintegra I tried the approach of not using the full text search here : #683. I think it solves the problem of performance. Since I had no longer access to scores, I had to redo the scoring logic but it's good, I think we could even reintroduce the keyword highlighting by doing it ourselves.

@ortnever and @Rdataflow Could you try some of your favorite searches on https://visualization-tool-git-feat-search-no-fulltext-ixt1.vercel.app/en/browse?dataSource=Prod to see if it matches your expectations ? Thanks

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

app/rdf/query-search.spec.ts Outdated Show resolved Hide resolved
@ortnever
Copy link

ortnever commented Sep 19, 2022

@ortnever and @Rdataflow Could you try some of your favorite searches on https://visualization-tool-git-feat-search-no-fulltext-ixt1.vercel.app/en/browse?dataSource=Prod to see if it matches your expectations ? Thanks

It looks very good. Even with a short abstract from the description, the result is displayed in 1-3 seconds. Thank you !

@ptbrowne ptbrowne merged commit 551a535 into main Sep 19, 2022
@ptbrowne ptbrowne deleted the feat/search-no-fulltext branch September 19, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants