Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout improvements #337

Merged
merged 18 commits into from
Feb 10, 2022
Merged

Layout improvements #337

merged 18 commits into from
Feb 10, 2022

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Feb 9, 2022

Fix #334

  • Remove the stepper (Process-Navigation) and add Call to actions. See invision doc here
  • Add process bar on top (Turn the red bar CI element into a process bar. See Invision doc here
  • Turn Back and Next Button into text links and put them on the outer left and right See Invision doc [here]
  • Keep “Publish” Button as Button but change the label to "Publish this visualization". See invision doc here
  • Change color of "Back to the data list" to grey #757575. See Invision doc here
  • Published chart: Change Share and Embed buttons from links to buttons. See invision doc here
  • Change Color of “Create new visualisation” and "Copy and edit this visualization" to grey #757575.
  • Change label of Copy visualization to "Copy and edit this visualization

@ptbrowne ptbrowne had a problem deploying to visualize-ad-new-steppe-7kfhtj February 9, 2022 18:26 Failure
@ptbrowne ptbrowne temporarily deployed to visualize-ad-new-steppe-7kfhtj February 9, 2022 18:28 Inactive
@ptbrowne ptbrowne had a problem deploying to visualize-ad-new-steppe-dtwc72 February 9, 2022 18:35 Failure
@ptbrowne ptbrowne temporarily deployed to visualize-ad-new-steppe-iuziav February 9, 2022 18:40 Inactive
@ptbrowne ptbrowne requested a review from AnninaWalker February 9, 2022 20:53
@AnninaWalker
Copy link
Contributor

Looks great @ptbrowne ! Love it! Only one minor thing: I think, we can get rid of the "Choose another dataset" as we have the Back Button now on top
Screenshot 2022-02-10 at 09 21 03 1

@ptbrowne
Copy link
Collaborator Author

ptbrowne commented Feb 10, 2022 via email

@ptbrowne ptbrowne temporarily deployed to visualize-ad-new-steppe-iuziav February 10, 2022 08:27 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-new-steppe-iuziav February 10, 2022 08:30 Inactive
@ptbrowne ptbrowne merged commit 84fb0a3 into main Feb 10, 2022
@ptbrowne ptbrowne deleted the new-stepper branch February 10, 2022 08:38
@ortnever
Copy link

Now that we are navigating with the "back" and "next" button I don't find it logical to go back to the page "all datasets" when we are on the page "Select a chart type"
The previous step in this case would be the data preview and not the list of datasets.
I understand your shortcut but I find it not very transparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Layout improvements
3 participants