Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page titles #331

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Page titles #331

merged 3 commits into from
Feb 7, 2022

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Feb 4, 2022

  • feat: Add page titles in browsing pages
  • feat: Add browsing title in dataset preview page
  • feat: Add page title when creating chart

fix #330

Examples

  • All datasets - visualize.admin.ch (while browsing all datasets, no search has been entered)
  • "penguins" - visualize.admin.ch (while browsing datasets, search has been entered)
  • Territory and environment - visualize.admin.ch (user has chosen a specific filter)
  • Palmer penguins - visualize.admin.ch (user is previewing a dataset)
  • Palmer penguins - visualize.admin.ch (user is creating a chart and has not chosen a title yet)
  • My chart about penguins - visualize.admin.ch (user has put a title to its chart)

@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-page--dftnkc February 4, 2022 14:06 Inactive
@ptbrowne ptbrowne merged commit c6fec51 into main Feb 7, 2022
@ptbrowne ptbrowne deleted the feat/page-titles branch February 7, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better page titles
1 participant
@ptbrowne