feat: Disable diverging palettes for maps #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM ! @l00mi Do you have any plans to put steps inside a dimension metadata (for example a median of the values) so that we can add diverging palettes ? For example for a column showing money earned/lossed, the step would be 0 and we would be able to use a diverging palette centered around 0. |
ptbrowne
approved these changes
Jan 27, 2022
That would be an annotation per MeasurmentDimension, right? I added this remark here: https://gitlab.ldbar.ch/bafu/umweltdatenkiosk-planning/-/issues/286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, I think it makes sense to temporarily disable divergent color palettes for maps for the time being, until clarified with Zazuko / internally.