Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New design for color scale palette picking for maps #294

Merged
merged 21 commits into from
Jan 27, 2022
Merged

feat: New design for color scale palette picking for maps #294

merged 21 commits into from
Jan 27, 2022

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jan 25, 2022 •
edited
Loading

Closes #275.

Besides updating design:

  • added ColorRampField (color picker which uses color ramps)
  • improved colors naming conventions (previously e.g. divergent scales were named as sequential)
  • added types for divergent and sequential color scales for maps & tables.

If you think this approach is good, then I can create an issue to also do this for other chart types and categorical color scales in the future.

@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 25, 2022 16:47 Inactive
@ptbrowne ptbrowne had a problem deploying to visualize-ad-feat-new-d-mkjyqc January 26, 2022 15:39 Failure
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 26, 2022 15:57 Inactive
@bprusinowski bprusinowski marked this pull request as ready for review January 26, 2022 16:02
@bprusinowski bprusinowski requested a review from ptbrowne January 26, 2022 16:02
@bprusinowski bprusinowski changed the title feat: New design for color picking maps feat: New design for color scale palette picking for maps Jan 26, 2022
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 26, 2022 16:25 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 26, 2022 16:48 Inactive
@bprusinowski
Copy link
Collaborator Author

@AnninaWalker I still need to replace a select element for choosing a number of breaks and use a text input; but if you could take a look and let me know if it looks good now, it would be helpful :)

https://visualize-ad-feat-new-d-mkjyqc.herokuapp.com/

@AnninaWalker
Copy link
Contributor

@bprusinowski It looks great! And honestly, I think the dropdown for the steps works even better, than an inputfield. I think I would leave it as it is!

@bprusinowski
Copy link
Collaborator Author

@AnninaWalker it's great to hear that! I'll leave the dropdown then :)

@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 27, 2022 09:12 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 27, 2022 09:22 Inactive
ptbrowne
ptbrowne approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good, my comments are nits, LGTM !

app/configurator/map/map-chart-options.tsx Show resolved Hide resolved
app/configurator/components/ui-helpers.ts Outdated Show resolved Hide resolved
app/configurator/components/ui-helpers.ts Show resolved Hide resolved
app/configurator/components/chart-controls/color-ramp.tsx Show resolved Hide resolved
app/configurator/components/chart-controls/color-ramp.tsx Show resolved Hide resolved
app/configurator/components/chart-controls/color-ramp.tsx Outdated Show resolved Hide resolved
app/configurator/components/chart-controls/color-ramp.tsx Show resolved Hide resolved
app/configurator/config-types.ts Show resolved Hide resolved
app/charts/map/map-state.tsx Show resolved Hide resolved
app/configurator/map/map-chart-options.tsx Outdated Show resolved Hide resolved
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 27, 2022 11:38 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 27, 2022 12:11 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 27, 2022 12:17 Inactive
@bprusinowski bprusinowski force-pushed the feat/new-design-for-color-picking-maps branch from bdd3a22 to b070e07 Compare January 27, 2022 12:25
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 27, 2022 12:25 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-new-d-mkjyqc January 27, 2022 12:35 Inactive
@bprusinowski bprusinowski merged commit 596fa48 into main Jan 27, 2022
@bprusinowski bprusinowski deleted the feat/new-design-for-color-picking-maps branch January 27, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne ptbrowne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maps: Area Layer - Design of Color Selection
3 participants
@bprusinowski @AnninaWalker @ptbrowne