Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use standard SPARQL IRI starting with <https://...> #1940

Merged

Conversation

Rdataflow
Copy link
Contributor

<foo> leads to unpredictable results
stardog: <tag:/foo>
fuseki: <http://server/unset-base/foo>
...

therefore let's stick to the SPARQL standard
thus switch to <https://visualize.admin.ch/foo>

cc @bprusinowski @Kronmar-Bafu @ZellerSabine

Copy link

vercel bot commented Dec 16, 2024

@Rdataflow is attempting to deploy a commit to the Interactive Things Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:01am

<foo> leads to unpredictable results
stardog: <tag:/foo>
fuseki: <http://server/unset-base/foo>
...
@Rdataflow Rdataflow force-pushed the fix-use-standard-sparql-iri branch from 7b4b9f8 to 4078702 Compare December 16, 2024 09:00
@Rdataflow
Copy link
Contributor Author

how to test:

  • observe Themes selection panel still appears in cube list view
  • observe Themes labels still appers in cube metadata

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rdataflow for catching this, LGTM!

@bprusinowski bprusinowski merged commit 716d2ae into visualize-admin:main Dec 16, 2024
1 of 2 checks passed
@Rdataflow Rdataflow deleted the fix-use-standard-sparql-iri branch December 16, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants