-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Image download #1931
Merged
+616
−88
Merged
feat: Image download #1931
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
615c1dc
chore: Add html-to-image
bprusinowski 85e46a4
feat: Add screenshot-making logic
bprusinowski 2ef7911
fix: Making screenshots of canvas elements
bprusinowski 90c905f
feat: Allow the MenuActionItem to be disabled
bprusinowski ebdd3c6
feat: Disable certain elements from being screenshotted
bprusinowski 53a9efa
feat: Add a way to screenshot charts
bprusinowski 5864301
docs: Update CHANGELOG
bprusinowski dd3c3d0
feat: Disable interactive filters panel from screenshots
bprusinowski 7668511
chore: Add meta-png
bprusinowski 98b957c
feat: Add a way to attach file metadata to PNG screenshots
bprusinowski 1723945
refactor: Extract
bprusinowski 3506fac
fix: Enable screenshots in published mode
bprusinowski f484bf7
feat: Disable more interactive elements from screenshots
bprusinowski 9810604
feat: Add better labels
bprusinowski 1aacf85
feat: Improve the Accent sync command
bprusinowski 246bf0c
feat: Remove SVG image export for now
bprusinowski 59e2be3
feat: Make all texts dark-grey in PNGs
bprusinowski af03396
refactor: Pass createdWith to VisualizeLink
bprusinowski d6ad38a
feat: Add Created with Visualize link to screenshot footnotes
bprusinowski 7571dc9
chore: Update react-table types
bprusinowski cd3eb7c
fix: Use React 18's createRoot to render additional screenshot elements
bprusinowski e65ec30
refactor: Move modifyNode closer to useScreenshot
bprusinowski d38201c
feat: Use better names for downloaded images
bprusinowski 506de01
feat: Add file metadata to downloaded PNG images
bprusinowski 75fd1fb
fix: Remove diacritics
bprusinowski b1cc7fc
feat: Improve publisher definition
bprusinowski d6e9c49
refactor: Extract TablePreviewWrapper
bprusinowski 1a8aa2c
refactor: Make it possible to access original node when making screen…
bprusinowski 0c4c21c
fix: Screenshotting of free canvas layout charts
bprusinowski ae9492d
feat: Disable map control elements
bprusinowski e9dba7b
feat: Remove attribution from map screenshots
bprusinowski d66cec2
fix: Make modifyNode async and await animation frame where needed
bprusinowski c8df4a7
fix: Typos
bprusinowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say yes, as
preserveDrawingBuffer
isfalse
by default and can decrease the performance of the map, the comment should make sure that we don't remove it and unknowingly break screenshotting of the maps :)