Bar chart #1920
Merged
Bar chart #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
reviewed
Dec 2, 2024
There was a problem hiding this comment.
@squiles I went over the PR and generally looks quite good already! 👏
I left some comments, most of which are nits or "thinking out loud" questions :) Let me know in case something is unclear 🥹
# Conflicts: # app/charts/column/columns-grouped.tsx # app/charts/column/columns.tsx # app/charts/index.ts # app/charts/line/lines.tsx # app/charts/shared/rendering-utils.ts # app/configurator/components/chart-options-selector.tsx
|
@squiles I've just reviewed again from my side and all the issues I've reported are fixed. I have just one question about the labels. Do we truncate them at a certain amount of characters? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.