Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve search options for add dataset dialog #1917

Merged
merged 10 commits into from
Nov 26, 2024
Merged

feat: Improve search options for add dataset dialog #1917

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
384e0d3
style: Align add dataset dialog search controls with the design
bprusinowski Nov 26, 2024
ed80659
refactor: Extract SearchDatasetSortControl
bprusinowski Nov 26, 2024
39dfe21
feat: Add a way to sort results in add dataset dialog
bprusinowski Nov 26, 2024
4ff833c
refactor: Extract SearchDatasetResultsCount
bprusinowski Nov 26, 2024
f594259
feat: Use SearchDatasetResultsCount in add dataset dialog
bprusinowski Nov 26, 2024
f9c1ef4
style: Do not apply border top for first result
bprusinowski Nov 26, 2024
7cd6150
refactor: Extract SearchDatasetDraftsControl
bprusinowski Nov 26, 2024
649862e
feat: Include SearchDatasetDraftsControl in add dataset dialog
bprusinowski Nov 26, 2024
2bf18ae
style: Align with the design
bprusinowski Nov 26, 2024
7d04275
docs: Update CHANGELOG
bprusinowski Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions app/browser/dataset-browse.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,7 +1015,7 @@ export const DatasetResults = ({
}

return (
<>
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must this be a div?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise &:not(:first-child) CSS selector can't target a proper element 🥹

{cubes.map(({ cube, highlightedTitle, highlightedDescription }) => (
<DatasetResult
key={cube.iri}
Expand All @@ -1025,7 +1025,7 @@ export const DatasetResults = ({
{...datasetResultProps?.({ cube })}
/>
))}
</>
</div>
);
};

Expand All @@ -1037,10 +1037,11 @@ const useResultStyles = makeStyles((theme: Theme) => ({
color: theme.palette.grey[700],
textAlign: "left",
padding: `${theme.spacing(4)} 0`,
borderTopColor: theme.palette.grey[300],
borderTopStyle: "solid",
borderTopWidth: 1,
boxShadow: "none",

"&:not(:first-child)": {
borderTop: `1px solid ${theme.palette.grey[300]}`,
},
},

titleClickable: {
Expand Down
Loading