Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed beta tag #1906

Merged
merged 4 commits into from
Nov 25, 2024
Merged

feat: removed beta tag #1906

merged 4 commits into from
Nov 25, 2024

Conversation

noahonyejese
Copy link
Contributor

@noahonyejese noahonyejese commented Nov 21, 2024

This PR:

How to test

  1. Go to this Link
  2. Select a Dataset for a visualization
  3. See how the beta Tag from the Datasets Section is removed

CC: @sosiology , @KerstinFaye

@noahonyejese noahonyejese self-assigned this Nov 21, 2024
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:55am

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @noahonyejese 👍

I think it could be cool to add a mention in the CHANGELOG that the merging of cubes beta tag was removed :)

Also I wonder if we shouldn't remove the beta tag from add dataset dialog? I know that the task was only mentioning this one place, but we also have the same tag related to merging of cubes there, might be worth to clarify with @sosiology.

@noahonyejese
Copy link
Contributor Author

@bprusinowski makes total sense, I will add it to the CHANGELOG for now and wait for the confirmation by @sosiology

@sosiology
Copy link
Contributor

@noahonyejese removal of the beta tag LGTM on the PR. Thanks.

@noahonyejese
Copy link
Contributor Author

@noahonyejese removal of the beta tag LGTM on the PR. Thanks.

should we me removing it, where @bprusinowski mentioned it as well?

@sosiology
Copy link
Contributor

@noahonyejese thanks for your question, sorry i missed it - lets discuss in our sync this morning

@noahonyejese noahonyejese merged commit 3ddc292 into main Nov 25, 2024
6 of 10 checks passed
@noahonyejese noahonyejese deleted the feat/remove-beta-tag branch November 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✓ Improve Visibility of Selected Data Set: Remove Beta Label
3 participants