-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed tooltip for Mobile Area Charts #1817
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall approach looks good to me, thank you @noahonyejese! There's another problem that probably was there before, that the tooltip can go out of the viewport – I wonder if we maybe can take a look at the same time?
@bprusinowski yeah I think the issue you mentioned above will resolve once we implement dynamic arrows |
Ah, but here it's not about the arrow, but that the whole tooltip can go out of viewport 👀 But maybe I missed something 👍 |
yeah technically good point its kinda both, where when we move the tooltip the arrow will be off and vise versa I will make sure it works once this is done |
Note: This doesn't include the Map and Pie Chart yet.
@bprusinowski I think everything works here, except for the Pie Chart, Map Chart and Scatter Plot. I will be updating the description for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @noahonyejese, LGTM 👏 Just a few nit comments 👍
@sosiology , @KerstinFaye this is ready for testing please free to compare everything w/ the designs as well: Design References:
|
@bprusinowski please check if this is the correct approach, if so I will continue implementing this for all charts and for tooltips that are larger the arrow will have to be more dynamic of course.
This PR:
This PR will resolve #94
How to Test
Go to this Visit Preview
Use the Einmalvergütung für Photovoltaikanlagen Dataset (you can test almost all Chart types w/ this)
Select Bar Chart -> Publish -> See how the tooltip is at the bottom with adjusting arrow ✅
Select Line Chart -> Publish -> See how the tooltip is at the bottom with adjusting arrow ✅
Select Area Chart -> Publish -> See how the tooltip is at the bottom with adjusting arrow ✅
Select Scatter Chart -> Publish -> See how the tooltip is at the bottom with adjusting arrow, but not optimal design ✅
Select Pie Chart -> Publish -> See how the tooltip is not placed correctly on mobile (potential separate issue), but is highlighted correctly ✅
Select Dual Axis Line Chart -> Publish -> See how the tooltip is at the bottom with adjusting arrow, but not optimal design ✅
Select Column Line Chart -> Publish -> See how the tooltip is at the bottom with adjusting arrow ✅
CC: @KerstinFaye , @sosiology