fix: Added Links for all Charts in Preview & Published Mode

[noahonyejese]

This PR fixes Issue #1813

How to Test

1. Go to this Link
2. Publish, a tab layout see how "Created with..." is visible ✅
3. Publish a Dashboard Layout with 1 Chart see how "Created with..." is in the Chart ✅
4. Publish a Dashboard Layout with more than 1 Chart see how the "Created with..." is only at the bottom of the layout ✅

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 0:05am

[bprusinowski]

Thanks @noahonyejese, I think we shouldn't show the Created with Visualize link during editing as is the case now on PROD 👀

Also, the How to test link doesn't work (I think you copied a /create link that points to a configurator state stored in your localStorage) – here one trick is to copy a link as shown in the screenshot that opens the editor mode for a given dataset 👍

[noahonyejese]

@bprusinowski So not show at all for any chart during preview / edit mode ?

[bprusinowski]

Yes, the issue was only that the link was missing in case of published dashboards 👍 So in editing mode we never show the link, and in published mode we show it inside individual chart if it's not a dashboard or a dashboard with one chart, or outside of dashboard group for dashboards with more than one chart 😄

[bprusinowski]

I see that @sosiology mentioned in the issue that it's not shown in the editing mode, but I am pretty sure we have never shown it here, and that could lead to some issues – if you click it, you'd go out of the editing mode and go back to the home page? 🤔 And we also don't have it in the design, so I'd scope this only to published charts (or we can discuss together 👍)

[bprusinowski]

LGTM, thanks! 💯

Btw, I noticed that you used a deployment link based on a commit in How to test instructions (https://visualization-tool-azw7yjcr8-ixt1.vercel.app/) – to make sure it stays up to date, you should use a deployment link based on a PR (https://visualization-tool-git-fix-created-reference-dashboards-ixt1.vercel.app/en) that updates automatically (I tried to test again after the most recent commit, but the deployment was not updated) :) This might be important for other people that test after some time 👍

[noahonyejese]

LGTM, thanks! 💯

Btw, I noticed that you used a deployment link based on a commit in How to test instructions (https://visualization-tool-azw7yjcr8-ixt1.vercel.app/) – to make sure it stays up to date, you should use a deployment link based on a PR (https://visualization-tool-git-fix-created-reference-dashboards-ixt1.vercel.app/en) that updates automatically (I tried to test again after the most recent commit, but the deployment was not updated) :) This might be important for other people that test after some time 👍

oh damn, thanks a lot!