Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove shared dashboard filters flag #1815

Merged
merged 1 commit into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ You can also check the

# Unreleased

Nothing yet.
- Features
- Removed a flag for shared dashboard filters

# [4.9.3] - 2024-10-29

Expand Down
4 changes: 1 addition & 3 deletions app/configurator/components/layout-configurator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,18 @@ import {
TemporalDimension,
TemporalEntityDimension,
} from "@/domain/data";
import { useFlag } from "@/flags";
import { useTimeFormatLocale, useTimeFormatUnit } from "@/formatters";
import { useConfigsCubeComponents } from "@/graphql/hooks";
import { useLocale } from "@/src";
import { useDashboardInteractiveFilters } from "@/stores/interactive-filters";
import { getTimeFilterOptions } from "@/utils/time-filter-options";

export const LayoutConfigurator = () => {
const sharedFiltersFlag = useFlag("layouter.dashboard.shared-filters");
return (
<>
<LayoutAnnotator />
<LayoutLayoutConfigurator />
{sharedFiltersFlag ? <LayoutSharedFiltersConfigurator /> : null}
<LayoutSharedFiltersConfigurator />
</>
);
};
Expand Down
1 change: 0 additions & 1 deletion app/flags/flag.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ const initFromHost = (host: string) => {
isVercelPreviewHost(host)
) {
setDefaultFlag("configurator.add-dataset.shared", true);
setDefaultFlag("layouter.dashboard.shared-filters", true);
}
};

Expand Down
2 changes: 0 additions & 2 deletions app/flags/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ export type FlagName =
| "debug"
/** Whether we can add dataset from shared dimensions */
| "configurator.add-dataset.shared"
/** Whether we can use shared filters on dashboard layout */
| "layouter.dashboard.shared-filters"
/** Whether server side cache is disabled */
| "server-side-cache.disable"
/** The GraphQL endpoint, is used for testing purposes */
Expand Down
Loading