Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Segmented line chart whisker colors #1768

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Sep 27, 2024

Fixes #1743

How to reproduce

  1. Go to this link.
  2. ❌ See that whiskers are all blue, making it hard to distinguish to which line they belong.

How to test

  1. Go to this link.
  2. ✅ See that whiskers take color from the line they belong to.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:58pm

Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bprusinowski bprusinowski merged commit ff7cf15 into main Sep 27, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the fix/error-whisker-colors branch September 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ error bars in segmented lines use misleading colors
2 participants