Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Smaller login improvements #1760

Merged
merged 2 commits into from
Sep 26, 2024
Merged

feat: Smaller login improvements #1760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906cc83
feat: Copy -> Duplicate
bprusinowski Sep 26, 2024
d0dbef0
feat: Remove share button
bprusinowski Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/locales/de/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,10 +1368,6 @@ msgstr "Filter anzeigen"
msgid "login.chart.actions.unpublish"
msgstr "Veröffentlichung aufheben"

#: app/login/components/profile-tables.tsx
msgid "login.chart.copy"
msgstr "Kopieren"

#: app/login/components/profile-tables.tsx
msgid "login.chart.delete"
msgstr "Löschen"
Expand All @@ -1384,6 +1380,10 @@ msgstr "Möchten Sie diesen Entwurf wirklich löschen?"
msgid "login.chart.delete.confirmation"
msgstr "Sind Sie sicher, dass Sie diese Grafik löschen wollen?"

#: app/login/components/profile-tables.tsx
msgid "login.chart.duplicate"
msgstr "Duplizieren"

#: app/login/components/profile-tables.tsx
#: app/pages/v/[chartId].tsx
msgid "login.chart.edit"
Expand Down
8 changes: 4 additions & 4 deletions app/locales/en/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,10 +1368,6 @@ msgstr "Show Filters"
msgid "login.chart.actions.unpublish"
msgstr "Unpublish"

#: app/login/components/profile-tables.tsx
msgid "login.chart.copy"
msgstr "Copy"

#: app/login/components/profile-tables.tsx
msgid "login.chart.delete"
msgstr "Delete"
Expand All @@ -1384,6 +1380,10 @@ msgstr "Are you sure you want to delete this draft?"
msgid "login.chart.delete.confirmation"
msgstr "Are you sure you want to delete this chart?"

#: app/login/components/profile-tables.tsx
msgid "login.chart.duplicate"
msgstr "Duplicate"

#: app/login/components/profile-tables.tsx
#: app/pages/v/[chartId].tsx
msgid "login.chart.edit"
Expand Down
8 changes: 4 additions & 4 deletions app/locales/fr/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,10 +1368,6 @@ msgstr "Afficher les filtres"
msgid "login.chart.actions.unpublish"
msgstr "Dépublier"

#: app/login/components/profile-tables.tsx
msgid "login.chart.copy"
msgstr "Copie"

#: app/login/components/profile-tables.tsx
msgid "login.chart.delete"
msgstr "Supprimer"
Expand All @@ -1384,6 +1380,10 @@ msgstr ""
msgid "login.chart.delete.confirmation"
msgstr "Êtes-vous sûr de vouloir supprimer cette carte ?"

#: app/login/components/profile-tables.tsx
msgid "login.chart.duplicate"
msgstr "Dupliquer"

#: app/login/components/profile-tables.tsx
#: app/pages/v/[chartId].tsx
msgid "login.chart.edit"
Expand Down
8 changes: 4 additions & 4 deletions app/locales/it/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,10 +1368,6 @@ msgstr "Mostra i filtri"
msgid "login.chart.actions.unpublish"
msgstr "Annullare la pubblicazione"

#: app/login/components/profile-tables.tsx
msgid "login.chart.copy"
msgstr "Copia"

#: app/login/components/profile-tables.tsx
msgid "login.chart.delete"
msgstr "Cancellare"
Expand All @@ -1384,6 +1380,10 @@ msgstr ""
msgid "login.chart.delete.confirmation"
msgstr "Sei sicuro di voler cancellare questo grafico?"

#: app/login/components/profile-tables.tsx
msgid "login.chart.duplicate"
msgstr "Duplicare"

#: app/login/components/profile-tables.tsx
#: app/pages/v/[chartId].tsx
msgid "login.chart.edit"
Expand Down
8 changes: 1 addition & 7 deletions app/login/components/profile-tables.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ const ProfileVisualizationsRow = (props: {
{
type: "link",
href: `/${locale}/create/new?copy=${config.key}`,
label: t({ id: "login.chart.copy", message: "Copy" }),
label: t({ id: "login.chart.duplicate", message: "Duplicate" }),
iconName: "copy",
},
{
Expand All @@ -224,12 +224,6 @@ const ProfileVisualizationsRow = (props: {
iconName: "edit",
priority: !isPublished ? 0 : undefined,
},
{
type: "link",
href: publishLink,
label: t({ id: "login.chart.share", message: "Share" }),
iconName: "linkExternal",
},
isPublished
? {
type: "button",
Expand Down
Loading