Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve chart tab titles #1730

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

noahonyejese
Copy link
Contributor

@noahonyejese noahonyejese commented Sep 9, 2024

This PR is to optimize the UX for adding and editing tab titles

Issue

  1. Go to this Link
  2. Add a second Chart
  3. Click on any Chart
  4. Notice how Add Label Button opens Add Label Options
  5. Scroll down to "Title & Description" Section Notice there is no way to edit tab label

How to test?

  1. Go to this Link
  2. Add a second Chart
  3. Click on any Chart
  4. Notice how Chart Changes without opening Tab Label Editor
  5. Click Dropdown Arrow
  6. See new Edit tab Label - Click on it and edit label
  7. Scroll down to "Title & Description" Section Notice you can edit tab title here as well.

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 9:15am

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

app/locales/de/messages.po Outdated Show resolved Hide resolved
@noahonyejese noahonyejese merged commit d3dc282 into main Sep 9, 2024
5 of 7 checks passed
@noahonyejese noahonyejese deleted the feat/improve-chart-tab-titles branch September 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants