Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search bots behavior #1726

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix: Search bots behavior #1726

merged 2 commits into from
Sep 6, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Sep 6, 2024

Fixes #1676

It looks like we had a legacy environmental variable – ALLOW_SEARCH_BOTS – that was not passed via the Dockerfile and couldn't be picked up during build. The exact rule we had in the code was "if ALLOW_SEARCH_BOTS is not 'true'", then disable the indexing, which resulted in the problem described in #1676.

I think it makes more sense to enable indexing by default, and disable it conditionally; that's why there's a new, PREVENT_SEARCH_BOTS variable to disable this behavior where needed.

Todo

  • Add PREVENT_SEARCH_BOTS=true env variable to Vercel
  • Add PREVENT_SEARCH_BOTS=true env variable to GitLab TEST pipeline
  • (after PR is approved): Reach out to Abraxas to add PREVENT_SEARCH_BOTS=true variable to INT pipeline (see ticket here)
  • PROD doesn't need a variable at all, once we deploy the behavior should be right due to reversed condition

cc @adintegra

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 1:35pm

...to prevent unit tests from failing.
Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bprusinowski bprusinowski merged commit 1298d50 into main Sep 6, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the seo/allow-robots branch September 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ Enable site indexing in Production
2 participants