Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve layouting step #1708

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Sep 4, 2024

This PR:

  • makes the page scroll to a shared filter when adding or removing the filters in the layouting step, so that users won't miss the fact that they were added at the top of the viewport,
  • makes the application remember past layouts when switching between them in the layouting step.

The latter could technically still be improved in a way that a previous layout is also kept when switching to editing step and back to layouting, but as I was unsure if this scenario of:

  1. Spending a lot of time doing free canvas layout.
  2. Switching to a tab layout.
  3. Going back to editing mode.
  4. Switching the layout back to free canvas layout.

would be very common, so I went with less complex implementation for now.

How to test

  1. Go to this link.
  2. Add a new chart.
  3. Proceed to layout options.
  4. Make the window small, and scroll to the bottom of the page.
  5. Activate a shared filter.
  6. ✅ See that the page was scrolled to the top.
  7. Switch to a dashboard / free canvas layout.
  8. Change the positions of charts.
  9. Toggle through dashboard sub-layouts (vertical, tall and free canvas).
  10. ✅ See that the layout was persisted.
  11. Switch to a tab layout, single URLs and dashboard layout again.
  12. ✅ See that the layout was persisted.

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 9:21am

@KerstinFaye
Copy link

That's great. Thanks @bprusinowski! I think for now we can really leave it like it is. When the user would go back to editing and then went again to layout step and switches to anther option, I think this could be kept in mind for a later point. But for now what you implemented is already fantastic.

Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, worked as described. 🎉

@bprusinowski bprusinowski merged commit 03c055c into main Sep 6, 2024
5 of 7 checks passed
@bprusinowski bprusinowski deleted the feat/general-improvements-2 branch September 6, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants