Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: General improvements #1707

Merged
merged 19 commits into from
Sep 4, 2024
Merged

feat: General improvements #1707

merged 19 commits into from
Sep 4, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Sep 3, 2024

This PR:

  • (merging of cubes) removes dimension selection from merging of cubes modal,
  • (login) adds time to last edit date in user profile,
  • (login) adds a new login popover menu when clicking on logged user name,
  • (dashboard) adds a new, 3-column layout to free canvas dashboard,
  • (general) updates styles and closing behavior of confirmation dialog.

How to test

Changes marked with (login) can only be tested on TEST after merging the PR.

To test other changes, go to this link and try to:

  • add a chart and remove it to see new dialog design,
  • add a new dataset to see removed dimension selector in the last step of the process,
  • add two new charts and go to layouting step, change the layout to dashboard / free canvas and resize the window to see that there's an intermediary layout with 3 columns.

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 7:11am

@bprusinowski bprusinowski self-assigned this Sep 3, 2024
@bprusinowski bprusinowski changed the base branch from main to feat/tab-labels September 3, 2024 13:29
Base automatically changed from feat/tab-labels to main September 3, 2024 14:45
@bprusinowski bprusinowski marked this pull request as ready for review September 3, 2024 14:59
Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. 😃

Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, I will review the visual to it once merged.

@bprusinowski bprusinowski merged commit 5954dfa into main Sep 4, 2024
3 of 4 checks passed
@bprusinowski bprusinowski deleted the feat/improvements-2 branch September 4, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants