perf: Optimize initializing chart from cube #1697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
1 task
noahonyejese
approved these changes
Aug 29, 2024
|
Ah, good catch @noahonyejese :) I forgot to mock the response for |
Yeah I've noticed that LINDAS is quite unstable sometimes.... |
|
Closing in favor of #1890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially closes #1658
This PR removes fetching of all dimensions with values in favor of re-using a cube preview query when initializing a chart from cube. I am not 100% convinced it improves the performance in a visible way, but at least we removed a potentially expensive query in favor of the preview one, that only fetches one dimension value for every dimension.