Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Table chart issues #1675

Merged
merged 4 commits into from
Jul 23, 2024
Merged

fix: Table chart issues #1675

merged 4 commits into from
Jul 23, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jul 23, 2024 •
edited
Loading

Fixes #1674
Fixes #1632

How to test

  1. Go to this link.
  2. Switch to a table chart.
  3. ✅ Look at the Columns section in the left panel and see that the drag handles are centered.
  4. Click on the Kanton column.
  5. Hide the column.
  6. ✅ See that Zürich option is highlighted as selected and when clicking on the radio buttons, they are also correctly highlighted.

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner July 23, 2024 11:45
@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 11:48am

@bprusinowski bprusinowski merged commit 5e6e078 into main Jul 23, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the fix/column-side-panel branch July 23, 2024 11:50
@bprusinowski bprusinowski changed the title fix: Column chart issues fix: Table chart issues Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne Awaiting requested review from ptbrowne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✅ Column chart issues Errors in the table module.
1 participant
@bprusinowski