Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Caching per cube iri in geo queries #1653

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

bprusinowski
Copy link
Collaborator

No description provided.

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner July 8, 2024 07:57
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 8:33am

@bprusinowski bprusinowski force-pushed the fix/caching-per-cube-iri branch from 031861d to 330039a Compare July 8, 2024 07:58
@bprusinowski
Copy link
Collaborator Author

bprusinowski commented Jul 8, 2024

@Rdataflow I went through the code again, and it looks like now it should be ok – the only queries where we don't have a cubeFilter variable which determines whether or not use the cube caching are SearchPage and SearchCubes queries, which aren't scoped per cube.

@bprusinowski bprusinowski merged commit 6061625 into main Jul 8, 2024
3 of 4 checks passed
@bprusinowski bprusinowski deleted the fix/caching-per-cube-iri branch July 8, 2024 08:29
@Rdataflow
Copy link
Contributor

@bprusinowski thank you for this fix - I'll be able to check tonight...

@Rdataflow
Copy link
Contributor

@bprusinowski Caching endpoint is good for all queries now👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants