Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dashboard time range filter and merging of cubes improvements #1644

Merged
merged 14 commits into from
Jul 1, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jun 27, 2024

Closes #1636

This PR refactors some areas of the application related to merging of cubes, so that we merge cubes in the context of a given chart config, instead of every config at the same time. This eliminates some bugs when dealing with several charts based on different cubes, and adding a new dataset to one of them after already having several charts.

It also simplifies the dashboard time range filter so that there is only one common filter for every temporal X dimension used in the charts. This means that we create a "combined" dimension that uses "lowest" time unit and are able to filter every chart afterwards with only one slider element.

How to test

PR

  1. Go to this link.
  2. Add a new chart (line).
  3. Merge a second dataset to the chart (Gebäudeprogramm - Anzahl unterstützter Gesuche).
  4. Add a new chart based on another cube (Bathing water quality).
  5. Add a new area chart, so that there are four charts in total.
  6. Proceed to layout options.
  7. Switch to dashboard / free canvas layout.
  8. ✅ See that there's one generic shared Date filter available.
  9. Toggle the filter on.
  10. ✅ See that the range encompasses every temporal X dimension (starts at 21.05.2007) and that it has a day resolution (lowest resolution based on year [Photovoltaikanlagen and Gebäudeprogramm datasets] and day [Bathing water quality dataset] temporal dimensions).
  11. See that the time slider appeared on top.
  12. Use the time slider to filter the charts, and see that every one of them reacts to the filtering.
  13. ✅ Reset the time slider to the full extent, and use the left date picker to select a new date, e.g. in June 2017. See that the charts reacted to the new selection.

TEST

  1. Go to this link.
  2. Add a new chart (line).
  3. Merge a second dataset to the chart (Gebäudeprogramm - Anzahl unterstützter Gesuche).
  4. Add a new chart based on another cube (Bathing water quality).
  5. Add a new area chart, so that there are four charts in total.
  6. Proceed to layout options.
  7. Switch to dashboard / free canvas layout.
  8. ❌ See that there are two shared filters available (1. Jahr der Vergütung, Jahr and 2. Date), which are not generic, but connected to 1. first two charts and 2. last two charts.
  9. Toggle the filters on.
  10. ❌ See that the ranges are implicitly based on year and day dimensions from different cubes.
  11. See that the time slider appeared on top.
  12. Use the time slider to filter the charts, and see that every one of them reacts to the filtering.
  13. ❌ Reset the time slider to the full extent, and use the left date picker in the Date field to select a new date, e.g. in June 2017. See that the charts didn't react to the new selection.

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner June 27, 2024 10:32
Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 3:49pm

@bprusinowski bprusinowski changed the title feat: Shared dashboard filters for different cubes feat: Shared dashboard time range filters for different cubes Jun 27, 2024
@bprusinowski bprusinowski force-pushed the feat/shared-dashboard-filters-for-different-cubes branch from dd3ef31 to 793347c Compare June 28, 2024 15:05
@bprusinowski bprusinowski changed the title feat: Shared dashboard time range filters for different cubes feat: Dashboard time range and merging of cubes improvements Jun 28, 2024
@bprusinowski bprusinowski changed the title feat: Dashboard time range and merging of cubes improvements feat: Dashboard time range filter and merging of cubes improvements Jun 28, 2024
@bprusinowski bprusinowski requested a review from KerstinFaye June 28, 2024 15:57
Copy link

@KerstinFaye KerstinFaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm impressed.

@bprusinowski bprusinowski merged commit 1a68bd6 into main Jul 1, 2024
5 of 7 checks passed
@bprusinowski bprusinowski deleted the feat/shared-dashboard-filters-for-different-cubes branch July 1, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅✅ Two shared filters are appearing for Dashboard
2 participants