-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dashboard time range filter and merging of cubes improvements #1644
Merged
bprusinowski
merged 14 commits into
main
from
feat/shared-dashboard-filters-for-different-cubes
Jul 1, 2024
Merged
feat: Dashboard time range filter and merging of cubes improvements #1644
bprusinowski
merged 14 commits into
main
from
feat/shared-dashboard-filters-for-different-cubes
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
changed the title
feat: Shared dashboard filters for different cubes
feat: Shared dashboard time range filters for different cubes
Jun 27, 2024
bprusinowski
force-pushed
the
feat/shared-dashboard-filters-for-different-cubes
branch
from
June 28, 2024 15:05
dd3ef31
to
793347c
Compare
bprusinowski
changed the title
feat: Shared dashboard time range filters for different cubes
feat: Dashboard time range and merging of cubes improvements
Jun 28, 2024
bprusinowski
changed the title
feat: Dashboard time range and merging of cubes improvements
feat: Dashboard time range filter and merging of cubes improvements
Jun 28, 2024
KerstinFaye
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'm impressed.
bprusinowski
deleted the
feat/shared-dashboard-filters-for-different-cubes
branch
July 1, 2024 12:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1636
This PR refactors some areas of the application related to merging of cubes, so that we merge cubes in the context of a given chart config, instead of every config at the same time. This eliminates some bugs when dealing with several charts based on different cubes, and adding a new dataset to one of them after already having several charts.
It also simplifies the dashboard time range filter so that there is only one common filter for every temporal X dimension used in the charts. This means that we create a "combined" dimension that uses "lowest" time unit and are able to filter every chart afterwards with only one slider element.
How to test
PR
Date
filter available.TEST
Date
field to select a new date, e.g. in June 2017. See that the charts didn't react to the new selection.