Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sub-theme filters #1643

Merged
merged 4 commits into from
Jun 27, 2024
Merged

fix: Sub-theme filters #1643

merged 4 commits into from
Jun 27, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jun 27, 2024

Closes #1641

This PR fixes sub-theme filters both on regular search page (URL-based) and in the modal search when adding a chart based on another cube (in-app-state-based).

How to test

PR

  1. Go to this link.
  2. Filter by Federal Office for the Environment FOEN (Organizations section).
  3. ✅ Filter by Climate and see that it works.
  4. Select Greenhouse gas emissions by sector and gas cube.
  5. Start a new visualization.
  6. Add a new chart based on another cube (click plus button, and afterwards a Select dataset button).
  7. Filter by Federal Office for the Environment FOEN (Organizations section).
  8. ✅ Filter by Climate and see that it works.

TEST

  1. Go to this link.
  2. Filter by Federal Office for the Environment FOEN (Organizations section).
  3. ❌ Filter by Climate and see that it doesn't work.
  4. Select Greenhouse gas emissions by sector and gas cube.
  5. Start a new visualization.
  6. Add a new chart based on another cube (click plus button, and afterwards a Select dataset button).
  7. Filter by Federal Office for the Environment FOEN (Organizations section).
  8. ❌ Filter by Climate and see that it doesn't work.

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner June 27, 2024 08:53
Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 8:57am

@bprusinowski bprusinowski merged commit 760dacc into main Jun 27, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the fix/subtheme-filters branch June 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subtheme selection filter doesn't work
1 participant