Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly initialize time filters in dashboard #1619

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix: Correctly initialize time filters in dashboard #1619

merged 1 commit into from
Jun 14, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jun 14, 2024 •
edited
Loading

Fixes #1618

How to test

PR

  1. Go to this link.
  2. ✅ See that the chart is loaded correctly (only shows years between 2017 and 2020).

TEST

  1. Go to this link.
  2. ❌ See that the chart is not loaded correctly (shows full data – between 2014 and 2022, while slider is constrained to 2017-2020).

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner June 14, 2024 12:15
@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 0:21am

@bprusinowski bprusinowski merged commit a245106 into main Jun 14, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the fix/dashboard-filter-initialization branch June 14, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne Awaiting requested review from ptbrowne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✅ Dashboard filters are not initialized correctly when presets are not default ones
1 participant
@bprusinowski