-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Activate shared filters for "tab" layout #1586
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but I think the state of the filters should be persisted when switching through the charts in the tab layout, otherwise the "shared" part doesn't really apply 😅 I can also take a look in the coming days, let me know 👍
Ah, I see that it's in fact persisted, it's just the slider that's initialized with the full range on switch 🤔 |
On a side note: I wonder if we shouldn't disable enter animations for charts (only for the initial render, filtering elements out or time-based animations should still persist this logic) – currently it's quite bad for a column chart (falls down from the top). This would also make it easier to compare the changes when switching thought the tabs, what do you think? The update animations could stay :) |
I'll take a look, thanks. |
7717770
to
72c3c15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Activate dashboard filters for tab layout