Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Activate shared filters for "tab" layout #1586

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

ptbrowne
Copy link
Collaborator

Activate dashboard filters for tab layout

  • In configurator mode
  • In published mode

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner June 10, 2024 14:46
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:45am

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I think the state of the filters should be persisted when switching through the charts in the tab layout, otherwise the "shared" part doesn't really apply 😅 I can also take a look in the coming days, let me know 👍

@bprusinowski
Copy link
Collaborator

Ah, I see that it's in fact persisted, it's just the slider that's initialized with the full range on switch 🤔

@bprusinowski
Copy link
Collaborator

bprusinowski commented Jun 10, 2024

On a side note: I wonder if we shouldn't disable enter animations for charts (only for the initial render, filtering elements out or time-based animations should still persist this logic) – currently it's quite bad for a column chart (falls down from the top). This would also make it easier to compare the changes when switching thought the tabs, what do you think? The update animations could stay :)

@ptbrowne
Copy link
Collaborator Author

I'll take a look, thanks.

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ptbrowne ptbrowne merged commit 51b0528 into main Jun 11, 2024
6 checks passed
@ptbrowne ptbrowne deleted the feat/tab-layout-shared branch June 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants