Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use npx knip to clean up unused things #1578

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

bprusinowski
Copy link
Collaborator

No description provided.

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner June 7, 2024 13:20
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 1:26pm

@bprusinowski bprusinowski changed the title refactor: Use npx knip to clean up unused things chore: Use npx knip to clean up unused things Jun 7, 2024
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome I did not know this tool. If the tests pass and some manual testing is done around the app, with merging cubes, and publishing etc... then I think we are good to go.

@bprusinowski
Copy link
Collaborator Author

bprusinowski commented Jun 7, 2024

Thanks 👍 It was not automated, I manually removed and checked every removed part of code, but will still test if nothing is broken 🧪 The tool just listed the things :)

@bprusinowski
Copy link
Collaborator Author

Everything seems to work the same 😄

@bprusinowski bprusinowski merged commit 2dd9fd3 into main Jun 7, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the chore/clean-up branch June 7, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants