Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initialize layout step when editing saved dashboard #1576

Merged

Conversation

bprusinowski
Copy link
Collaborator

Closes #1550

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner June 7, 2024 10:46
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 0:27am

@bprusinowski bprusinowski force-pushed the feat/intialize-layout-step-when-editing-dashboard branch from 723c90d to 77d61ed Compare June 7, 2024 10:47
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 I like that this approach gives us the flexibility also go to the CONFIGURATOR_CONFIGURING_CHART state in the future if we need it. Or any other step :)

@bprusinowski bprusinowski force-pushed the feat/intialize-layout-step-when-editing-dashboard branch from 77d61ed to 684cbde Compare June 7, 2024 12:22
@bprusinowski bprusinowski merged commit 555f08d into main Jun 7, 2024
3 of 4 checks passed
@bprusinowski bprusinowski deleted the feat/intialize-layout-step-when-editing-dashboard branch June 7, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ Edit saved dashboard - jump to layout options
2 participants