Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Full data download (merged cubes) #1571

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix: Full data download (merged cubes) #1571

merged 2 commits into from
Jun 7, 2024

Conversation

bprusinowski
Copy link
Collaborator

Fixes #1536

@bprusinowski
fix: Full data download (merged cubes)
3a15277 
...as footnotes are duplicated per cube, we need to pass queryFilters per cube, so the full data download works and is scoped to the correct dataset.
@bprusinowski bprusinowski requested a review from ptbrowne as a code owner June 7, 2024 07:45
@vercel Vercel
Copy link

vercel bot commented Jun 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 0:21am

@ptbrowne
Copy link
Collaborator

ptbrowne commented Jun 7, 2024

I do not understand what's happening here ? Do we a joinBy iri inside dataCubeMetadata.iri in case of merged cubes ?

@bprusinowski
Copy link
Collaborator Author

Currently, we pass queryFilters which is an array in case of having merged cubes. As full data download is scoped per given dataset, we need to pass correct query filters (per given cube) 👍

ptbrowne
ptbrowne approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation !

@bprusinowski
Copy link
Collaborator Author

I refactored to make it clear from the code 👍

@bprusinowski bprusinowski merged commit 8f24b07 into main Jun 7, 2024
3 of 4 checks passed
@bprusinowski bprusinowski deleted the fix/full-data-download-merged-cubes branch June 7, 2024 12:18
@ptbrowne ptbrowne mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne ptbrowne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✅ Full data set cannot be downloaded when cubes are merged
2 participants
@bprusinowski @ptbrowne