Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repairing tests #1569

Merged
merged 34 commits into from
Jun 10, 2024
Merged

Repairing tests #1569

merged 34 commits into from
Jun 10, 2024

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Jun 6, 2024 •
edited
Loading

Remove uncertainty due to changing data

  • Making sure tests are using recorded HARs
    • Allowing to control the graphql endpoint to be set via flag so that when we launch the test, we can instrument the app to use http://localhost:3000. This would be needed for tests using HARs otherwise the HAR containing traces with http://localhost:3000/api/graphql cannot be matched with requests to <VERCEL_URL>/api/graphql.
    • Making it more easy to add traces through the replayFromHAR fixture
    • Adding more traces
      • Abbrevatiations
      • Ordinal measures
      • Sorting
      • Search

Deactivate tests that do not pass on CI

For a reason that I still cannot explain, some tests do not pass on CI while they pass on local machine. I tagged them as @noci and make it so that the tests do not run on the CI (via --grep-invert @noci).

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner June 6, 2024 15:23
@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 9:44pm

@ptbrowne ptbrowne marked this pull request as draft June 6, 2024 15:24
@ptbrowne ptbrowne marked this pull request as ready for review June 9, 2024 22:30
bprusinowski
bprusinowski approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👌

Any suspicions on why some tests do not work on CI? 🕵️‍♂️

@ptbrowne ptbrowne merged commit 2e55915 into main Jun 10, 2024
6 checks passed
@ptbrowne ptbrowne deleted the fix/tests branch June 10, 2024 10:59
@ptbrowne ptbrowne mentioned this pull request Jun 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprusinowski bprusinowski bprusinowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptbrowne @bprusinowski