Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync dashboard layouts with chart configs #1566

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Sync dashboard layouts with chart configs #1566

merged 5 commits into from
Jun 6, 2024

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Jun 5, 2024

This makes sure that while we are adding and removing chart configs, when we go back to the canvas, the the charts have a correct size (previously they would be very tiny).
Also it makes it easier to resize the last charts vertically by adding a margin bottom to the canvas layout in preview mode.

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner June 5, 2024 16:21
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 10:15am

@ptbrowne ptbrowne changed the title Sync dashboard layouts with chart congis Sync dashboard layouts with chart configs Jun 5, 2024
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

app/configurator/configurator-state/reducer.tsx Outdated Show resolved Hide resolved
app/configurator/configurator-state/reducer.tsx Outdated Show resolved Hide resolved
@ptbrowne ptbrowne merged commit 113015f into main Jun 6, 2024
5 of 6 checks passed
@ptbrowne ptbrowne deleted the feat/new-chart branch June 6, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants