Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use cache bounded as prescribed by the warning #1564

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Jun 5, 2024

The default cache of Apollo 3 is using an unbounded cache by default,
which would be vulnerable to denial of service attacks.

The warning was issued when the application was started and Philipp from
Abraxas told us about that.

Persisted queries are enabled and are using an unbounded cache. Your
server is vulnerable to denial of service attacks via memory exhaustion.
Set cache: "bounded" or persistedQueries: false in your ApolloServer
constructor, or see https://go.apollo.dev/s/cache-backends for other
alternatives.

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner June 5, 2024 13:35
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 1:45pm

Persisted queries are enabled and are using an unbounded cache. Your
server is vulnerable to denial of service attacks via memory exhaustion.
Set `cache: "bounded"` or `persistedQueries: false` in your ApolloServer
constructor, or see https://go.apollo.dev/s/cache-backends for other
alternatives.
@ptbrowne ptbrowne merged commit d0d65d2 into main Jun 5, 2024
5 of 6 checks passed
@ptbrowne ptbrowne deleted the feat/bounded-cache branch June 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants