Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP features behind flags #1557

Merged
merged 9 commits into from
Jun 5, 2024
Merged

WIP features behind flags #1557

merged 9 commits into from
Jun 5, 2024

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Jun 4, 2024

Goal

Allowing to deploy to int without features that have not been approved by
BAFU.

Here the following functionalities are put behind flags.

  • Searching cubes via termsets
  • Merging of cube
  • Free canvas functionality for dashboard
  • Adding new chart from new dataset

Those flags are set automatically on test.visualize.admin.ch, on Vercel
previews, and on localhost.

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner June 4, 2024 12:27
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:00pm

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

app/flags/store.ts Outdated Show resolved Hide resolved
app/flags/flag.tsx Show resolved Hide resolved
@ptbrowne ptbrowne merged commit c947553 into main Jun 5, 2024
5 of 6 checks passed
@ptbrowne ptbrowne deleted the feat/flags branch June 5, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants