Dashboard canvas works in published mode #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
force-pushed
the
fix/dashboard-published
branch
from
acb9441 to
6a5a667
Compare
- Correctly pass className, children and ref for ChartPublished to work in dashboard canvas - fix: Disable resizing when not in layouting
ptbrowne
force-pushed
the
fix/dashboard-published
branch
from
6a5a667 to
9a9595f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard canvas works in published mode
I had not repercuted some of the improvements from chart-preview to chart-published.
Passing ref, className, and children is necessary for react-grid-layout to work
correctly.