Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard action menu #1541

Merged
merged 17 commits into from
May 29, 2024
Merged

Dashboard action menu #1541

merged 17 commits into from
May 29, 2024

Conversation

ptbrowne
Copy link
Collaborator

Add action menu for layout mode allowing the user to go back to the chart
and go back to the configure mode.
Align the menu used in the configure mode to use the ArrowMenu to have
coherence between the views.

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner May 29, 2024 10:22
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 3:20pm

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Wondering if the action menu shouldn't be there in Tab layout too? 👀

app/config-types.ts Show resolved Hide resolved
app/configurator/configurator-state.tsx Outdated Show resolved Hide resolved
app/configurator/configurator-state.tsx Outdated Show resolved Hide resolved
app/components/chart-selection-tabs.tsx Outdated Show resolved Hide resolved
app/configurator/components/add-new-dataset-panel.tsx Outdated Show resolved Hide resolved
@KerstinFaye
Copy link

@ptbrowne I tested adding a chart based on a different dataset:

  1. Add chart
  2. Select different dataset
  3. Preview table
  4. I closed the search overlay with the close-icon to cancel that process
  5. I go again to add a chart based on a different dataset
  6. The overlay shows the data preview table to the chart that I selected in the process before

---> Could we achieve that the process of selecting a dataset is canceled by closing the overlay, meaning when I selected the next time a dataset that I don't end up directly at the preview?

Video of the problem

@ptbrowne ptbrowne merged commit 86d242f into main May 29, 2024
5 of 6 checks passed
@ptbrowne ptbrowne deleted the feat/dashboard-action-menu branch May 29, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants