Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromatic #1531

Merged
merged 2 commits into from
May 28, 2024
Merged

Chromatic #1531

merged 2 commits into from
May 28, 2024

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented May 27, 2024

Chromatic build

Trying out Figma-Storybook integration. For the integration with the Figma Storybook-connect plugin, we need the storybook to be published to Chromatic.

  • Builds storybook and sends it to Chromatic. Now, the storybook is published both via the public/ folder and via Chromatic.
  • Since we use Argos for snapshots testing, we disable snapshots globally, Chromatic is only
    for hosting

- Disable snapshots (we use Argos)
- Project token configured via GitHub CI
- Builds in the same directory as storybook:build command
@ptbrowne ptbrowne requested a review from bprusinowski as a code owner May 27, 2024 11:29
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 11:48am

@ptbrowne ptbrowne force-pushed the feat/chromatic branch 2 times, most recently from 52db4da to 0d79866 Compare May 27, 2024 11:33
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

How can I access Chromatic, I couldn't find a password in 1Password and didn't get an invitation – is it just to test the things "unofficially" now? 👀

@ptbrowne
Copy link
Collaborator Author

ptbrowne commented May 28, 2024

@bprusinowski It should work if you connect to Chromatic via Github.

From Chromatic:

GitHub repository: visualize-admin/visualization-tool
This project syncs collaborators with visualize-admin/visualization-tool on GitHub. Collaborators must login to Chromatic with GitHub to appear on the list. Because this is a public repository, only direct members of the repository or organization are shown.

@ptbrowne ptbrowne merged commit fc7874d into main May 28, 2024
5 of 6 checks passed
@ptbrowne ptbrowne deleted the feat/chromatic branch May 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants