Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation dashboard 2 #1518

Merged
merged 10 commits into from
May 16, 2024
Merged

Preparation dashboard 2 #1518

merged 10 commits into from
May 16, 2024

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented May 16, 2024

Another preparation PR that will make introduction of the grid layout easier.

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner May 16, 2024 12:30
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 1:51pm

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

app/components/react-grid.tsx Outdated Show resolved Hide resolved
app/locales/de/messages.po Outdated Show resolved Hide resolved
app/components/chart-preview.tsx Show resolved Hide resolved
… downgrade ts-pattern to 4

- ts-jest is not supported yet on typescript@5, we need to use typescript@4
- ts-pattern@5 not compatible with typescript@4, we need to use ts-pattern@4
@ptbrowne ptbrowne force-pushed the feat/preparation-dashboard-2 branch from 91d9174 to fcf51b3 Compare May 16, 2024 13:41
@ptbrowne ptbrowne merged commit 98ab1df into main May 16, 2024
3 of 4 checks passed
@ptbrowne ptbrowne deleted the feat/preparation-dashboard-2 branch May 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants