Preparation dashboard #1516
Merged
Preparation dashboard #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icular chart context
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
force-pushed
the
feat/preparation-dashboard
branch
from
56b54cd to
edd42f0
Compare
bprusinowski
approved these changes
May 16, 2024
There was a problem hiding this comment.
LGTM 💯
When testing, I noticed one issue (which is also there on TEST, so not a regression, but related to this area I think):
- Go to https://visualization-tool-git-feat-preparation-dashboard-ixt1.vercel.app/en/create/new?cube=https://energy.ld.admin.ch/sfoe/bfe_ogd84_einmalverguetung_fuer_photovoltaikanlagen/9&dataSource=Prod
- Add a second chart.
- Go back to first chart.
- Go to X axis.
- Enable interactive filter.
- Proceed to layout options.
- See that the chart changes filter range to 2014-2014.
I can also open a new issue, let me know 👍
Co-authored-by: Bartosz Prusinowski <[email protected]>
|
Thanks for the thorough review, I've created an issue for the problem you saw 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InteractiveFilters state has been lifted up, out of the chart themselves, inside a global InteractiveFilters provider, which creates one zustand store for each chart, and then provides it to the charts through InteractiveFiltersChartProvider. This will enable control of multiple interactive filters by one component.