fix: Keep errors in one container #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k in case of errors
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
changed the title
ptbrowne
reviewed
May 8, 2024
| </HintBlue> | ||
| </Box> | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
Maybe we could have a ChartWarnings here that would have the logic to extract errors, display, and wrap them ?
This way we would not have to repeat the logic ? I guess we would need to have a way to filter some errors ?
<ChartWarnings ignore={['imputation']} /> // in preview
f482763 to
0920355
Compare
|
@bprusinowski Do you think you could take a little time to rebase this PR and fix the error 🙏 ? I guess we could forgo the refactor I was proposing, in the interest of getting this PR out 😅 |
|
Sure, @ptbrowne you mean the merge conflict? |
…into fix/dashboard-layout-errors
ptbrowne
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a container to encompass all errors, so the
subgridlayout doesn't break in case of errors. To see what's broken currently, see this link.