-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Redirects to latest cube #1391
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
huh, the current state of this PR breaks unversioned cubes like i.e. eletricity price |
a050eff
to
106b48c
Compare
Thanks for catching this @Rdataflow, I corrected the query 🤞 |
@bprusinowski according to my tests it works as expected now for versioned (superseeded and current) [i.e. NFI] as well as non-versioned [i.e. electricity prices] 👍 |
…into fix/redirects-to-latest-cube
28fedbd
to
40dbe5c
Compare
40dbe5c
to
a438418
Compare
a438418
to
81efb24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Fixes #1390.
I think the problem was that we didn't treat the cube with version "2023-2" as versioned cube and failed to fetch latest iri. This PR solves this on a SPARQL query level (and removes relying on checking if a cube is versioned by a heuristic).
With this change, we try to look for newest version of the cube if an older version was passed in the URL (respecting published status).
How to test
PR
TEST