Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Non-optional accessor #1363

Merged
merged 2 commits into from
Feb 23, 2024
Merged

fix: Non-optional accessor #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4625eab
fix: Non-optional accessor
bprusinowski Feb 23, 2024
05f187c
docs: Update CHANGELOG
bprusinowski Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

You can also check the [release page](https://github.com/visualize-admin/visualization-tool/releases)

# [3.26.1] - 2023-12-22
## Unreleased

- Fixes
- The application no longer breaks in specific cases when filters were re-loaded

# [3.26.1] - 2024-02-23

- Fixes
- Ability to copy/edit previous charts

# [3.26.0] - 2023-12-21
# [3.26.0] - 2024-02-20

- Features
- Layout step is now available without using a flag
Expand Down
4 changes: 3 additions & 1 deletion app/configurator/components/field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,9 @@ export const DataFilterSelect = ({

const canUseMostRecentValue = isTemporalOrdinalDimension(dimension);
const usesMostRecentValue = isDynamicMaxValue(fieldProps.value);
const maxValue = sortedValues[sortedValues.length - 1].value;
// Dimension values can be empty just before a filter is reloaded through
// ensurePossibleFilters
const maxValue = sortedValues[sortedValues.length - 1]?.value;

return (
<Select
Expand Down
Loading