Fix tests

[ptbrowne]

• fix: Color mapping test
• fix: Temporal filter test broken
• fixed: After layout adjustments we now use different test-id
• fix: Order of default filters has changed on this cube

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 22, 2024 4:34pm

[bprusinowski]

Thanks @ptbrowne, the situation looks much better now :)

Would it also make sense to remove the below part of GitHub Action?

visualization-tool/.github/workflows/e2e.yml

Lines 36 to 62 in 7c05360

	- name: E2E tests ✅
	if: ${{ success() }}
	# set the merge commit status check
	# using GitHub REST API
	# see https://docs.github.com/en/rest/reference/repos#create-a-commit-status
	run: |
	curl --request POST \
	--url https://api.github.com/repos/${{ github.repository }}/statuses/${{ github.sha }} \
	--header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \
	--header 'content-type: application/json' \
	--data '{
	"context": "e2e",
	"state": "success",
	"description": "E2E tests passed"
	}'
	- name: E2E tests 🚨
	if: ${{ failure() }}
	run: |
	curl --request POST \
	--url https://api.github.com/repos/${{ github.repository }}/statuses/${{ github.sha }} \
	--header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \
	--header 'content-type: application/json' \
	--data '{
	"context": "e2e",
	"state": "failure",
	"description": "E2E tests failed"
	}'

It looks like the state is mirrored between this and built-in check status in PRs, or maybe I'm missing something 💭

[bprusinowski]

Wondering if we could maybe extract this to a const and reuse it here and in the layout file, so we can't forget about updating it in the future? Maybe it could be adapted for all test-ids across the app, what do you think? Or should the "testId" name automatically ring a bell to update an e2e test? 😅

[ptbrowne]

I think the broken test should automatically ring a bell 😁 I will try to make a const file 👍

[ptbrowne]

Would it also make sense to remove the below part of GitHub Action?

Yes it seems like so, I don't remember know why we have this 😅