Save draft #1352
Merged
Save draft #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ptbrowne
commented
Feb 20, 2024
•
ptbrowne
commented
- Reduce flickering the 1st time we save a draft (not changing the page)
- Correctly saving published state the 1st time when we first create the config : I had not seen this because I had first put published state's default as "DRAFT" in Prisma schema locally, then had changed it to default=PUBLISHED without running the migration. Then on test, the default was PUBLISHED and I could see that at creation time, published draft was not taken into account. After running prisma migrate locally, I could reproduce the bug and fix it.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
published state was not saved correctly before the 1st time we would save in draft. I had not seen this because I had first put @default=DRAFT in Prisma locally, then had changed it to @default=PUBLISHED without running the migration. Then on test, the default was PUBLISHED and I could see that saving in draft would not work for the 1st time
After saving in draft, save locally instead of switching page
ptbrowne
force-pushed
the
fix/save-draft
branch
from
5168d03 to
5247f00
Compare
bprusinowski
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Code looks good! 👌
Not related to this PR, but while playing around with the feature on TEST I noticed that I can't edit the charts I created some time ago (see video). It looks like there's a need to apply migrations to chart config for every action we do (View, Edit, ...) 👀
bug.720p.mov
|
Thanks Bartosz, I created another issue for this. Since people do not have charts yet, I also think it is not too much of an issue 😅 . |
|
@ptbrowne yup, but if they start making them now and we introduce a new property in the config, it will become an issue in the future 👀 Thanks for creating an issue 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.