Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update k6 performance tests II #1336

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Feb 14, 2024

This PR:

  • increases number of test iterations from 1 to 2 to decrease number of false-positives (long query duration caused by some factor not related to code change),
  • adds k6_http_req_duration_avg metric to the payload sent to Prometheus (average request duration computed from 2 iterations),
  • adds data correctness checks to every GQL performance test.

These changes are coordinated with accompanying changes to Grafana dashboard.

...and subsequently change the Grafana charts measure to k6_http_req_duration_avg. This should reduce number of false-positives of going over the threshold.
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 3:15pm

@bprusinowski bprusinowski marked this pull request as ready for review February 14, 2024 15:11
@bprusinowski bprusinowski merged commit 0b4f5fd into main Feb 14, 2024
3 of 4 checks passed
@bprusinowski bprusinowski deleted the chore/update-k6-performance-tests branch February 14, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant