Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Single URLs layout #1326

Merged
merged 11 commits into from
Feb 5, 2024
Merged

feat: Single URLs layout #1326

merged 11 commits into from
Feb 5, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Feb 2, 2024

Closes #1325.

This PR introduces a single URLs layout mode, where user can publish several charts separately.

A new browser tab is opened for every chart, instead of the first one, which behaves in a regular way (goes to /v/chart-id?publishSuccess=true page).

How to test

⚠️ Publishing possible to test when deployed to TEST.

  1. Go to the preview link (only to test the non-publishing behavior) or to TEST link (once merged).
  2. Add more charts.
  3. Proceed to layout options.
  4. Change layout mode to Single URLs.
  5. See that it's possible to check charts to be published separately.
  6. Click Publish button and see that every selected chart has been published in a different tab, with unique URL.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 1 resolved Feb 5, 2024 3:32pm

@bprusinowski bprusinowski changed the base branch from main to feat/improve-responsiveness February 2, 2024 09:58
Base automatically changed from feat/improve-responsiveness to main February 2, 2024 13:34
@bprusinowski bprusinowski merged commit 96fbdfe into main Feb 5, 2024
3 of 5 checks passed
@bprusinowski bprusinowski deleted the feat/single-urls-layout branch February 5, 2024 08:29
@KerstinFaye
Copy link

KerstinFaye commented Feb 5, 2024

Looks really good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compositions: Single URLs layout mode
2 participants