-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add drag and drop to Dashboard layouts #1322
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @ptbrowne, thanks for reviewing and testing 💯 I adjusted the drag and drop behavior a bit to hide the dragged element and disable animations when creating an overlay, I think it is better now. I initially tried with moving the chart instead of using overlay, but it was quite "messy", especially for Tall layout, when the thing you drag suddenly changes size in the middle of page scroll, I think it's more clean when we need to "confirm" the action. Let me know if the new behavior is still confusing, it would be also great to get @KerstinFaye's view on this 🎨 We've also discussed limiting the width of the edit / publish views with @KerstinFaye, I'll introduce the changes in later PRs 👍 |
bd24a3b
to
6aab460
Compare
Thanks a lot for your great work @bprusinowski and for your testing and feedback @ptbrowne.
|
This PR adds a drag and drop functionality to Dashboard layouts (Vertical and Tall) in the edit mode.
How to test