-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Optimize dataset preview performance #1299
perf: Optimize dataset preview performance #1299
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3d64e64
to
ae0eb59
Compare
ae0eb59
to
c742930
Compare
c742930
to
f9d3c3b
Compare
f9d3c3b
to
d89b229
Compare
d89b229
to
406c3b3
Compare
a7f2e51
to
9467c6d
Compare
@Rdataflow dataset preview for BLW cubes is broken due to errors in the data, see that the landing page is localized while it shouldn't be: https://s.zazuko.com/2ionzw1. It works on TEST, because there we query for cube metadata using the old way, while now we switched to a dedicated query ( This problem will be addressed in the near future by Zazuko 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
@bprusinowski well done 🎉 |
This PR improves the performance of fetching dataset preview by ditching the current logic (using
rdf-cube-view-query
library) in favor of a customCONSTRUCT
query. It also removesRun SPARQL query
button from dataset preview page.In the future, we might also adapt and extract the logic to be reused when fetching components, to avoid querying the whole shape (and e.g. unit labels separately, as was the case before) and instead focus on the properties that we actually need.
Improvement: one of the largest datasets (Electricity tariff per provider) loads in around 5s on TEST; in the PR, it takes around 0.5s.
Thanks @Rdataflow for the inspiration and providing an example query 🎉