fix: Better scope pragmas to fix data cube preview query #1285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to better scope pragmas when fetching the cube preview by using a clean Source, without pragmas, as having
#pragma join.hash off
breaks previews for some cubes for yet unknown reasons (see e.g. https://test.visualize.admin.ch/en/browse?previous=%7B%7D&dataset=https%3A%2F%2Fenvironment.ld.admin.ch%2Ffoen%2Fnfi%2Fnfi_C-94%2Fcube%2F2023-1&dataSource=Prod).Context
For more information see this conversation on Zulip.
Notes
I aimed for a simple solution by overriding
getMainSource
View's method, which might not be ideal, but:How to test
NFI: Topics by ownership
cube.