-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): ✅ fix E2E tests #1269
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@bprusinowski for NFI cubes we need to rely on those published on PROD. you may ping @kronmar to learn how to update the charts... |
multi root hierarchy retrieval > should work for C-1029
|
@lloydrichards maybe it would make sense to change the config to base on PROD cubes, as suggested by @Rdataflow. I think you could make a new chart based on such cube, and copy the configurator state from DebugPanel / LocalStorage to the |
it should display values in interactive filters as hierarchie |
For the multi-root hierarchies, I also think it might be more future-proof to switch to the PROD cube. But as the way of fetching hierarchies has changed in #1244, I would wait with adapting this one until the mentioned PR is merged 👀 |
Filters > Filters initial state should have hierarchy dimensions first and topmost value selected
|
For the it should display values in interactive filters as hierarchie, it looks that sometimes there's a problem with |
Yes, just checked, Cube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Thanks a lot @lloydrichards ! |
Goals/Scope
There are a number of E2E tests that are failing, making it harder to judge if the dependabot can be safely merged in. From the latest github Actions there are 14 failing tests.
Description
Completed
add testID prop for the data-testid on ChartTypeButtons
should be possible to de-select options from color component in map
should be possible to only select table & map
should be possible to select ordinal measure as area color
it should display values in interactive filters as hierarchie
Segment sorting with hierarchy
Map legend preview table sorting
Sorting with values with same label as other values in the tree
tooltip content
Selecting SymbolLayer colors> should be possible to select geo dimension and see a legend
Filters initial state should have hierarchy dimensions first and topmost value selected
Skipped
Chart Snapshots map-nfi int ipad-mini, portrait
Chart Snapshots map-nfi int iphone-8, portrait
multi root hierarchy retrieval › should work for C-1029
Comments
This PR is to act as a benchmark so I can figure out overtime which E2E tests are still failing.